diagnostic_aggregator: catkin_make -DCATKIN_ENABLE_TESTING=0 fails

[bulwahn]

When executing catkin_make -DCATKIN_ENABLE_TESTING=0, it fails with:

Linking CXX executable (...)/diagnostics_ws/devel/lib/diagnostic_aggregator/analyzer_loader
/usr/bin/ld: cannot find -lgtest
collect2: error: ld returned 1 exit status
make[2]: *** [(...)/diagnostics_ws/devel/lib/diagnostic_aggregator/analyzer_loader] Error 1

diagnostic_aggregator in version 1.8.4 needs the gtest library, but this is only discovered for linking when testing is enabled in catkin.

[trainman419]

The self_test package already does this. Why is it a problem in diagnostic_aggregator and not in self_test?

[trainman419]

I've fixed this in the https://github.com/ros/diagnostics/tree/include_gtest branch by including the gtest sources in the packages that need them. Can you test that this works on your system before I merge?

[bulwahn]

I tested it and it solves the problem for my setup. I have never tested the self_test package. Maybe you can try executing 'catkin_make -DCATKIN_ENABLE_TESTING=0' for self_test?

[trainman419]

This is fixed in #28 and released as 1.8.5 into Hydro ( ros/rosdistro#5149 ) and Indigo ( ros/rosdistro#5150 )

[trainman419]

Dirk and Tully seem to think #28 was a bad idea; care to comment?

[trainman419]

Closing due to lack of response from @bulwahn