Blacklist image tools py #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
added
in review
mjcarroll
approved these changes
Jan 2, 2019
clalancette
force-pushed
the
blacklist-image-tools-py
branch
from
4ecbcb0
to
f493842
Compare
clalancette
force-pushed
the
blacklist-image-tools-py
branch
from
f493842
to
ce67565
Compare
|
@clalancette - this appears to have been reviewed. Is it ready to be merged? |
|
@cottsay I was waiting to merge this until ros2/demos#107 is approved/merged, since it is not necessary until then. But I'm fine to put it in now if you think we should. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
blacklist-image-tools-py
branch
from
89ba5f2
to
0bb60f7
Compare
|
I'm going to merge this one in, so we'll be ready for ros2/demos#107 when it is approved and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blacklist image_tools_py on Xenial, since there is no OpenCV python bindings for Python3 there. Also install python3-opencv on non-Xenial Linux targets.
connects to ros2/demos#85