Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change rmw_implementation deps to be buildtool and not exec #99

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 1, 2020

Discovered this while going over dependencies again with @chapulina. I think it should be build tool and not exec.

@wjwwood wjwwood added the enhancement New feature or request label May 1, 2020
@wjwwood wjwwood self-assigned this May 1, 2020
@ahcorde
Copy link
Contributor

ahcorde commented May 1, 2020

Can you reorder these two new lines to follow the schema order ?

@wjwwood
Copy link
Member Author

wjwwood commented May 1, 2020

How do you mean? I think they are in that order? Do you mean move them above the lines around them? This package already has a mixture of depend and other tags, so I didn't try to reorder everything.

@dirk-thomas
Copy link
Member

@wjwwood What is the status on this?

@wjwwood
Copy link
Member Author

wjwwood commented Jun 25, 2020

Sorry, this fell through the cracks. When you poked me originally, I hesitated to merge it now because I was worried it shouldn't go into foxy. But I can merge it and then decide if we should back port it. Any thoughts on if it should be back ported?

@dirk-thomas
Copy link
Member

From a Debian point of view this is a no-op and (to my knowledge) we nowhere use these dependency types differently anywhere else. Therefore I don't mind if it does get backported or not.

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood requested review from ahcorde and removed request for ahcorde June 25, 2020 17:18
@wjwwood
Copy link
Member Author

wjwwood commented Jun 25, 2020

@ahcorde can you re-review this?

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants