Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change expected rmw GID array size to 16 bytes #138

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Change expected rmw GID array size to 16 bytes #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test_tracetools/test/test_generic_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_all(self):

for event in rmw_sub_init_events:
self.assertValidHandle(event, ['rmw_subscription_handle'])
self.assertValidStaticArray(event, 'gid', int, 24)
self.assertValidStaticArray(event, 'gid', int, 16)
for event in rcl_sub_init_events:
self.assertValidHandle(
event,
Expand Down
2 changes: 1 addition & 1 deletion test_tracetools/test/test_publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def test_all(self):
rmw_pub_init_events = self.get_events_with_name(tp.rmw_publisher_init)
for event in rmw_pub_init_events:
self.assertValidHandle(event, ['rmw_publisher_handle'])
self.assertValidStaticArray(event, 'gid', int, 24)
self.assertValidStaticArray(event, 'gid', int, 16)
pub_init_events = self.get_events_with_name(tp.rcl_publisher_init)
for event in pub_init_events:
self.assertValidHandle(
Expand Down
2 changes: 1 addition & 1 deletion test_tracetools/test/test_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def test_all(self):

for event in rmw_sub_init_events:
self.assertValidHandle(event, ['rmw_subscription_handle'])
self.assertValidStaticArray(event, 'gid', int, 24)
self.assertValidStaticArray(event, 'gid', int, 16)
for event in rcl_sub_init_events:
self.assertValidHandle(
event,
Expand Down
2 changes: 1 addition & 1 deletion tracetools/include/tracetools/tp_call.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#include "tracetools/version.h"

/// See RMW_GID_STORAGE_SIZE in rmw.
#define TRACETOOLS_GID_STORAGE_SIZE 24u
#define TRACETOOLS_GID_STORAGE_SIZE 16u

#ifdef __clang__
# pragma clang diagnostic push
Expand Down
Loading