Add mechanism to disable workaround for dependency groups (#157)

Signed-off-by: Scott K Logan <logans@cottsay.net>
ros2 · Jun 5, 2024 · 23af193 · 23af193
1 parent 1abcb7f
commit 23af193
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/rosidl_typesupport_c/package.xml b/rosidl_typesupport_c/package.xml
@@ -21,12 +21,9 @@
   <depend>rcutils</depend>
 
   <build_depend>rosidl_runtime_c</build_depend>
-  <!--
-  Bloom does not support group_depend so entries below duplicate the group rosidl_typesupport_c_packages.
-  This ensures that binary packages have support for all of these rmw impl. enabled.
-  -->
-  <build_depend>rosidl_typesupport_introspection_c</build_depend>
-  <!-- end of group rosidl_typesupport_c_packages for bloom -->
+
+  <!-- Explicit group resolution - see ros-infrastructure/catkin_pkg#369 -->
+  <build_depend condition="$DISABLE_GROUPS_WORKAROUND != 1">rosidl_typesupport_introspection_c</build_depend>
 
   <buildtool_export_depend>ament_cmake_core</buildtool_export_depend>
   <build_export_depend>rosidl_runtime_c</build_export_depend>

diff --git a/rosidl_typesupport_cpp/package.xml b/rosidl_typesupport_cpp/package.xml
@@ -21,12 +21,9 @@
   <depend>rcpputils</depend>
   <build_depend>rosidl_runtime_c</build_depend>
   <build_depend>rosidl_typesupport_c</build_depend>
-  <!--
-  Bloom does not support group_depend so entries below duplicate the group rosidl_typesupport_cpp_packages.
-  This ensures that binary packages have support for all of these rmw impl. enabled.
-  -->
-  <build_depend>rosidl_typesupport_introspection_cpp</build_depend>
-  <!-- end of group rosidl_typesupport_cpp_packages for bloom -->
+
+  <!-- Explicit group resolution - see ros-infrastructure/catkin_pkg#369 -->
+  <build_depend condition="$DISABLE_GROUPS_WORKAROUND != 1">rosidl_typesupport_introspection_cpp</build_depend>
 
   <buildtool_export_depend>ament_cmake_core</buildtool_export_depend>
   <build_export_depend>rosidl_typesupport_c</build_export_depend>