Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMAKE_STAGING_PREFIX for staging OGRE installation (backport #861) #866

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 10, 2022

This is an automatic backport of pull request #861 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

To maintain build/install phasing correctly, this vendor package is
installing the external project to a staging location, which is then
recursively copied to the final location during the vendor package's
installation phase.

The mechanism by which we're currently telling the external project
where to install to gives it the impression that that will be the final
destination, and it embeds such paths in places like pkgconfig files.

The CMAKE_STAGING_PREFIX can be used to override all of the `install()`
operations' targets while still telling the project where it will
eventually end up, which is pretty much exactly what we're trying to do.

Signed-off-by: Scott K Logan <logans@cottsay.net>
(cherry picked from commit 47e91ee)
@cottsay
Copy link
Member

cottsay commented Jun 13, 2022

I'd like to wait until we've seen this patch in action in Rolling before we merge here.

@cottsay cottsay self-assigned this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant