Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust specs to work with strict Mocks kwargs checks #2993

Closed
wants to merge 2 commits into from
Closed

Adjust specs to work with strict Mocks kwargs checks #2993

wants to merge 2 commits into from

Conversation

pirj
Copy link
Member

@pirj pirj commented Jan 3, 2023 •
edited
Loading

Prerequisite to make CI for rspec/rspec-mocks#1514 pass

We are passing options as kwargs, but were expecting an options hash.

Example failure

@pirj pirj self-assigned this Jan 3, 2023
@pirj pirj requested review from JonRowe and benoittgt January 3, 2023 12:40
@pirj pirj mentioned this pull request Jan 3, 2023
Merged
@eregon
Copy link
Contributor

eregon commented Jan 3, 2023

rspec/rspec-mocks#1514 (comment)

@pirj
Copy link
Member Author

pirj commented Jan 4, 2023

This seems unnecessary now

@pirj pirj closed this Jan 4, 2023
@pirj pirj deleted the make-ruby-3.2-kwargs-expectations-stricter branch January 4, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt benoittgt approved these changes

@JonRowe JonRowe Awaiting requested review from JonRowe

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirj @eregon @benoittgt