Clean up generator for generator specs #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m happy to merge it on green CI. I guess it’s a matter of removing two chars? |
Don't force pluralization of the generator name in the generated spec and use the full generator name in the spec description. Also clean up an extra whitespace and empty line in the template. Note that the generator class constant cannot be directly used in the spec description as it isn't loaded by default.
budu
force-pushed
the
clean-generator-spec-generator
branch
from
7d4ce37
to
a7489f5
Compare
|
Done, totally missed the cucumber specs, sorry! |
|
Thank you! |
JonRowe
pushed a commit
that referenced
this pull request
Mar 18, 2024
Clean up generator for generator specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force pluralization of the generator name in the generated spec and use the full generator name in the spec description.
Also clean up an extra whitespace and empty line in the template.
Note that the generator class constant cannot be directly used in the spec description as it isn't loaded by default.