Skip to content

Commit

Permalink
Prevent invalid encoding for files blowing up
Browse files Browse the repository at this point in the history
  • Loading branch information
JonRowe committed Feb 5, 2019
1 parent 29f8cd5 commit 8bc3b72
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/rspec/support/source.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ class Source
attr_reader :source, :path

def self.from_file(path)
source = File.read(path)
# We must use `binread` here, there is no spec for this behaviour
# as its proven troublesome to replicate within our spec suite, but
# to manually verify run:
# `bundle exec rspec spec/support/source_spec.broken_example`
source = File.binread(path)
new(source, path)
end

Expand Down
8 changes: 8 additions & 0 deletions spec/support/source_spec.broken_example
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Encoding.default_internal = Encoding::BINARY

describe UndeclaredModule do
# the missing constant can be anything
it 'crashes and does not even parse this' do
'привет'
end
end

0 comments on commit 8bc3b72

Please sign in to comment.