test(vscode): widen multiroot E2E diagnostic deadline for slow runners - #32
Merged
Conversation
The 'parent → child → parent' ownership-handoff test waits for the new owning folder's lint worker to cold-start and publish its first diagnostic. On GitHub's windows runners that cold start has exceeded upstream's 30s deadline (CI run 32718392387, attempt 1), failing the suite with 0 diagnostics after the handoff. Widen waitForSingleRslintDiagnostic's deadline to 60s and the suite timeout to 240s. Assertion semantics are unchanged; the deviations from the upstream-ported suite are documented inline per AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI run 32718392387 (attempt 1,
E2E (windows-latest)) failed in the Multi-root dynamic ownership suite:hands a document parent → child → parent without reopening itasserted0 !== 1afterwaitForSingleRslintDiagnostic's 30s deadline expired.Diagnosis: an ownership handoff spawns a fresh lint worker for the new owning folder (resolve core → init → lint → publish). On GitHub's windows runners that cold start exceeded 30s once; the old owner had already cleared the document's diagnostics, so the wait returned 0. Same code passed windows E2E 6× on the PR branch and on rerun (attempt 2) — a timing flake, not a regression.
What
waitForSingleRslintDiagnosticdeadline: 30s → 60sAssertion semantics are unchanged. Upstream (web-infra-dev/rslint
origin/main) still uses 30s/60s; the deviations are documented inline per the ported-suite rule inpackages/vscode/AGENTS.md.Verified
pnpm lint && pnpm test:unitgreenVSCODE_CLI=1 RSTACK_LINT_E2E_SUITES="Multi-root" pnpm test:e2e lint— both Multi-root suites pass locally