Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double-tilde for strikethrough in Markdown tests #4144

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

yihui
Copy link
Member

@yihui yihui commented Oct 13, 2024

The current dev version of commonmark has disabled single tilde for strikethrough: r-lib/commonmark#33 Using double-tilde will make it consistent with Pandoc's Markdown (where single-tilde is for subscripts).

The current dev version of commonmark has disabled single tilde   for strikethrough: r-lib/commonmark#33 Using double-tilde will make it consistent with Pandoc's Markdown (where single-tilde is for subscripts).
@cpsievert
Copy link
Collaborator

Thanks, do you have a timeline in mind for submitting commonmark to CRAN?

@yihui
Copy link
Member Author

yihui commented Oct 15, 2024

I don't, but Jeroen just made a release earlier this month and I'm currently proposing another feature to commonmark, so the next release may not happen very soon.

This particular issue is not urgent, but it will make it possible for me to get rid of an ugly hack in my package. If you can make a new CRAN release of shiny at some point this year, that should be good enough to me. Thanks!

@yihui
Copy link
Member Author

yihui commented Oct 15, 2024

You don't have to skip tests for lower versions of commonmark, because double-tilde works for lower versions, too. Perhaps I didn't make it clear:

  • For commonmark <= 1.9.2, both ~text~ and ~~text~~ generate strikethroughs.
  • For commonmark > 1.9.2, only ~~text~~ does.

@cpsievert cpsievert merged commit a145add into main Oct 15, 2024
12 checks passed
@cpsievert cpsievert deleted the double-tilde branch October 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants