Add another good example for RelativeDateConstant

The current good example seems to discourage the usage of a constant completely. Add another good example to showcase how to continue using a constant and have things working dynamically.
rubocop · Dec 14, 2019 · 703f18e · 703f18e
1 parent 8dd305c
commit 703f18e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/rubocop/cop/rails/relative_date_constant.rb b/lib/rubocop/cop/rails/relative_date_constant.rb
@@ -14,6 +14,15 @@ module Rails
       #
       #   # good
       #   class SomeClass
+      #     EXPIRES = 1.week
+      #
+      #     def self.expired_at
+      #       EXPIRES.since
+      #     end
+      #   end
+      #
+      #   # good
+      #   class SomeClass
       #     def self.expired_at
       #       1.week.since
       #     end

diff --git a/manual/cops_rails.md b/manual/cops_rails.md
@@ -1900,6 +1900,15 @@ class SomeClass
   EXPIRED_AT = 1.week.since
 end
 
+# good
+class SomeClass
+  EXPIRES = 1.week
+
+  def self.expired_at
+    EXPIRES.since
+  end
+end
+
 # good
 class SomeClass
   def self.expired_at