Fire input and change event on set for color input - #230
Merged
Conversation
Member
|
looks like tests are failing |
Since a color input has to have its value set directly via javascript (presumably because of the difficulty of interacting with the browser's colour picker), the `change` and `input` events don't automatically happen. This PR fires them manually. Fixes rubycdp#229
route
force-pushed
the
dispatch-events-on-set-color-input
branch
from
August 24, 2026 14:22
72a8548 to
d0b9878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a color input has to have its value set directly via javascript (presumably because of the difficulty of interacting with the browser's colour picker), the
changeandinputevents don't automatically happen. This PR fires them manually.Fixes #229