Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vitally destination #1795

Conversation

jason-vitally
Copy link

@jason-vitally jason-vitally commented Jan 17, 2023

Description of the change

Adds Vitally as a new destination. The only transformation needed is:

  • attach API key to the authorization header
  • drop events that aren't group, identify and track

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

config-generator
transformer
rudderstack-docs

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Feb 7, 2023
@jason-vitally
Copy link
Author

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

Commenting to keep this PR from getting stale. I spoke with @ItsSudip in a shared Slack about these PRs and they said this should be reviewed shortly

@github-actions github-actions bot removed the Stale label Feb 8, 2023
@github-actions
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Mar 22, 2023
@ItsSudip
Copy link
Member

Hey @jason-vitally as we have released this integration through another pr we are closing this. You can follow this link for documentation details and this link for the repo.

@ItsSudip ItsSudip closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants