Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releases, publish notifications to slack on broken releases #2028

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Aug 22, 2023

This PR attempts to fix the KEVM release process, which hasn't succeeded in a while. In particular:

  • We post to #kevm-notifications on Slack when a release suceeds/fails.
  • We change the with-docker github action to properly label the input as a contianer-name, not a tag.
  • Removes the jdk option to the with-docker action, because it's unused.
  • We additionally allow setting the image tag name.
  • We update the push to dockerhub to use the new tag name.

@ehildenb ehildenb self-assigned this Aug 22, 2023
@ehildenb ehildenb marked this pull request as ready for review August 22, 2023 18:07
@rv-jenkins rv-jenkins merged commit 506821c into master Aug 23, 2023
12 checks passed
@rv-jenkins rv-jenkins deleted the release-fix branch August 23, 2023 06:25
iFrostizz pushed a commit that referenced this pull request Aug 28, 2023
* .github/master-push: publish notification to slack on release success/failure

* .github/: update to use tag => container-name in with-docker action

* Set Version: 1.0.273

* .github/master-push: publish dockerhub image with correct tag identifier

---------

Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants