-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default max_depth
= 25000, no break-on-calls
#2032
Conversation
There seems to be a proof failing because an output obtained from the is different - I am confused why this could be showing up with this change - could it be that the output depends on |
Hmmmm, is it actually different, or just failing the proof because of flakiness? The booster seems to think it has the same structure as before, so I'd be surprised if it was actually different output. I guess we may need to look more closely at it. |
It could be flakiness, I just saw it fail twice in the same way, so I flagged. |
It just failed in the same way right now... |
I can confirm that there is a problem with the output, here is a snippet: OBTAINED:
EXPECTED:
from which you can see two things:
|
@PetarMax thanks for the investigation, I'll look into it! I wanted to check if the test is failing locally too, but had problems running tests on my machine. It's strange that it doesn't fail when the booster is on though. |
Hmmmm, some thoughts:
|
929f9e5
to
cb24a0a
Compare
Out of date. |
Partially addresses #1958.
This PR is aimed to improve the default observable performance of KEVM by making
no-break-on-calls
default and increasing default--max-depth
to25000
.