Hotfix/gh pages #2035
Merged
Hotfix/gh pages #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…submodules, k-web-theme isn't setup properly adding explicit submodule init and update
ehildenb
reviewed
Aug 24, 2023
ehildenb
approved these changes
Aug 24, 2023
|
To answer your other question, the k-web-theme submodule was still being used as part of the npm build definition in web/package.json |
iFrostizz
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Do not remove gitmodules * gh-pages needs the .gitmodules info to checkout appropriate web/ and submodules, k-web-theme isn't setup properly adding explicit submodule init and update * Set Version: 1.0.276 * Remove manual submodule checkout * Set Version: 1.0.277 * Set Version: 1.0.278 --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think I figured out what's wrong with the gh-pages build. This should fix it. I have a temp repository built on my local box I can try to push the gh-pages with if we'd like to try it first before releasing this into CI.