Removing #rangeBool reasoning
#2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Some of) the added lemmas are tested by some of the I am not sure what a reasonable test that is not direct would look like. |
PetarMax
commented
Sep 10, 2024
ehildenb
reviewed
Sep 10, 2024
Comment on lines
+93
to
+96
| // Relationship with `#rangeBool` | ||
| rule [b2w-rangeBool-eq-not-zero-l]: bool2Word (notBool (X ==Int 0)) => X requires #rangeBool(X) [simplification, comm] | ||
| rule [b2w-rangeBool-eq-not-zero-r]: bool2Word (notBool (0 ==Int X)) => X requires #rangeBool(X) [simplification, comm] | ||
|
|
There was a problem hiding this comment.
Do we also want the ones for X ==Int 1 and 1 ==Int X?
There was a problem hiding this comment.
I don't think so, at least not for now, because these ones (the one with X ==Int 0 specifically, and then I added the commutative version) come from the compiler as a check that something is a bool.
ehildenb
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lemmas removed in this PR slow down execution of some real-world proofs considerably because the
rangeBoolconstraints are SMT-checked for every expression of the formnotBool ( X ==Int 0 )ornotBool ( X ==Int 1 ).The lemmas brought in reflect the (so-far-observed) checks made by the compiler, and their LHS is complex enough so they it will not be matched against unnecessarily.