Skip to content

Commit

Permalink
Correct comments
Browse files Browse the repository at this point in the history
  • Loading branch information
geo2a committed Aug 5, 2024
1 parent 10f6b18 commit 7f7d667
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion booster/library/Booster/JsonRpc.hs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ respond stateVar request =

case evaluatedInitialPattern of
(Left ApplyEquations.SideConditionFalse{}, _) -> do
-- input pattern's constrains are Bottom, return Bottom
-- input pattern's constraints are Bottom, return Vacuous
stop <- liftIO $ getTime Monotonic
pure $
execResponse
Expand Down
6 changes: 3 additions & 3 deletions booster/library/Booster/Pattern/ApplyEquations.hs
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ evaluatePattern' ::
EquationT io Pattern
evaluatePattern' pat@Pattern{term, ceilConditions} = withPatternContext pat $ do
solver <- (.smtSolver) <$> getConfig
-- check initial constraints for consistency, reporting an error if they are Bottom
-- check the pattern's constraints for consistency, reporting an error if they are Bottom
withContext CtxConstraint
. withContext CtxDetail
. withTermContext (coerce $ collapseAndBools pat.constraints)
Expand All @@ -479,15 +479,15 @@ evaluatePattern' pat@Pattern{term, ceilConditions} = withPatternContext pat $ do
throw . SideConditionFalse . collapseAndBools $ pat.constraints
Left SMT.SMTSolverUnknown{} -> do
-- unlikely case of an Unknown response to a consistency check.
-- What to do here? continue for now to preserver the old behaviour.
-- continue to preserver the old behaviour.
withContext CtxConstraint . logWarn . Text.pack $
"Constraints consistency UNKNOWN: " <> show consistent
continue
Left other ->
-- fail hard on SMT error other than @SMT.SMTSolverUnknown@
liftIO $ Exception.throw other
Right True -> do
-- constrains are consistent, continue
-- constraints are consistent, continue
continue
where
continue = do
Expand Down

0 comments on commit 7f7d667

Please sign in to comment.