Handle inconsistent ground truth and SMT unknowns when checking ensures
#4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
force-pushed
the
ensures-unsat-ground-truth-check
branch
from
2ee1aba
to
c34a3a7
Compare
We abort when checking ensured conditions of rewrite rules if the ground truth is UNSAT or the SMT solver returned Unkwnon
geo2a
force-pushed
the
ensures-unsat-ground-truth-check
branch
from
c34a3a7
to
8e9c7c2
Compare
jberthold
approved these changes
Oct 17, 2024
| @@ -188,12 +198,28 @@ finaliseSolver ctxt = do | |||
| Log.logMessage ("Closing SMT solver" :: Text) | |||
| destroyContext ctxt | |||
|
|
|||
| pattern IsUnknown :: unknown -> Either unknown b | |||
| data UnkwnonReason | |||
There was a problem hiding this comment.
Suggested change
| data UnkwnonReason | |
| data UnknownReason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking
ensuresconditions of rewrite rules with the SMT solver, we must mark rewrite as trivial if the ground truth is inconsistent. If the SMT solver returns unknown, we must abort rewriting.Previously, we were swallowing both of there cases and finalizing the rewrite step successfully. This behavior of Booster went undetected for a long time since we would usually abort rewriting or detect a vacuous state at the next step, resulting in wasted work but no unsoundness.
We also tweak the return type of
checkPredicatesto convey addition information why the result is unknown. This will be useful when we start tolerating SMT unknowns and branching on that.