Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hidden visibility flag #4666

Merged
merged 1 commit into from
Oct 17, 2024
Merged

add hidden visibility flag #4666

merged 1 commit into from
Oct 17, 2024

Conversation

dwightguth
Copy link
Collaborator

This PR adds a flag to kompile which passes through to the llvm backend. Fairly straightforward.

@rv-jenkins rv-jenkins changed the base branch from master to develop October 17, 2024 15:56
ehildenb
ehildenb approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@ehildenb ehildenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, do you need these options in pyk too?

@dwightguth
Copy link
Collaborator Author

No.

@dwightguth dwightguth merged commit 82039ee into develop Oct 17, 2024
18 checks passed
@dwightguth dwightguth deleted the hidden branch October 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehildenb ehildenb ehildenb approved these changes

@Scott-Guest Scott-Guest Awaiting requested review from Scott-Guest

@rv-jenkins rv-jenkins Awaiting requested review from rv-jenkins

@F-WRunTime F-WRunTime Awaiting requested review from F-WRunTime

@tothtamas28 tothtamas28 Awaiting requested review from tothtamas28

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwightguth @ehildenb