Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Timer Hook Implementation for K #4673

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Adding Timer Hook Implementation for K #4673

merged 5 commits into from
Oct 23, 2024

Conversation

Robertorosmaninho
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho commented Oct 22, 2024

Follow up of runtimeverification/llvm-backend#1131

This Hook is commonly used to measure VM time in Semantics executions.

The execution of a semantics with timerStart and timerStop produces a hook_time.txt file with the difference of two timestamps in nanoseconds.

@Robertorosmaninho Robertorosmaninho self-assigned this Oct 22, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop October 22, 2024 21:22
@ehildenb
Copy link
Member

Why does this need to exist as a dedicated hook? Shouldn't shelling out to date and writing the results to a file work for this too, which would use existing hooks?

@Robertorosmaninho
Copy link
Collaborator Author

Hey Everett, not really. With a dedicated hook, we can select the granularity of the measurement we would like to do. These hooks provide a simple and generic interface to measure the whole execution, a transaction, a rule evaluation, and opcodes execution! We have been using it for a few months now only updating the branch that contains it. However, to automate the measurement of KEVM, for example, to get some key performance numbers to present at DevCon, we would like to have it merged and available to use inside a Dockerfile without the need to build K.

@rv-jenkins rv-jenkins merged commit 8a20bdb into develop Oct 23, 2024
18 checks passed
@rv-jenkins rv-jenkins deleted the timer-hook-impl branch October 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants