This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Parallel prover implementation for APRProofs #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication/pyk into noah/parallel-prover
…fication/pyk into noah/parallel-prover
…r, and strengthen type signatures
nwatson22
commented
Feb 9, 2024
…erification/pyk into noah/apr-proof-parallel
tothtamas28
reviewed
Feb 12, 2024
| @@ -76,7 +80,7 @@ class ProofStep(ABC, Generic[U]): | |||
| """ | |||
|
|
|||
| @abstractmethod | |||
| def exec(self) -> U: | |||
| def exec(self, data: D) -> U: | |||
There was a problem hiding this comment.
My understanding is that data is fixed for a given run of prove_parallel. What's the advantage of providing data as an argument to exec and not in __init__ of the Prover implementation?
There was a problem hiding this comment.
Yes, it is now fixed, but I'm still using at as a way to only pass in large objects to the worker threads once at the beginning. With the way you suggest is there a different way exec could get access to the data?
There was a problem hiding this comment.
Prover instantiates ProofStep, so if Prover has access to data, then it can also pass it to ProofStep during instantiation. The exec method then reads data from its instance.
…erification/pyk into noah/apr-proof-parallel
…erification/pyk into noah/apr-proof-parallel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParallelAPRProverandParallelAPRBMCProver, which implementParallelProverinterface for APR and APRBMC proofsProcessData, implemented byAPRProcessData, for passing in data into a process at the beginning and sharing data within the same process, but between different tasksprove_parallelAPRProver,APRProof, andAPRProcessDataBlocked on runtimeverification/hs-backend-booster#383Blocked on runtimeverification/evm-semantics#2272