Merge pull request #1514 from Anmol-Baranwal/fix_terminal_warnings

fix: terminal warnings and remove unnecessary code
rupali-codes · Aug 9, 2023 · 15a3408 · 15a3408 · vercel · Aug 9, 2023
2 parents e283b2d + 2e4b99d
commit 15a3408
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 12 deletions.
diff --git a/components/Searchbar/Searchbar.tsx b/components/Searchbar/Searchbar.tsx
@@ -67,8 +67,10 @@ export const Searchbar: React.FC<SearchbarProps> = ({ setSearch }) => {
   return (
     <form onSubmit={handleSubmit} noValidate>
       <div className="relative">
-        <div className="flex items-center" aria-role="search">
-          <label htmlFor="simple-search" className="sr-only">Quickly search any resources</label>
+        <div className="flex items-center" role="search">
+          <label htmlFor="simple-search" className="sr-only">
+            Quickly search any resources
+          </label>
           <input
             type="text"
             id="simple-search"

diff --git a/components/Share/Share.tsx b/components/Share/Share.tsx
@@ -1,4 +1,4 @@
-import React, { useState } from 'react'
+import React from 'react'
 import { FiShare2 } from 'react-icons/fi'
 import { Tooltip } from 'react-tooltip'
 
@@ -8,7 +8,7 @@ type ShareProps = {
 }
 
 export const Share: React.FC<ShareProps> = ({ url, title }) => {
-  const [showShareOptions, setShowShareOptions] = useState(false)
+  const showShareOptions = false
 
   async function handleShare() {
     if (navigator.share) {
@@ -34,15 +34,29 @@ export const Share: React.FC<ShareProps> = ({ url, title }) => {
         display: 'inline-block',
       }}
     >
-      <button data-tooltip-id="share-tooltip" data-tooltip-content="Share" data-tooltip-place="bottom">
-      <FiShare2
-        size={'1.2rem'}
-        className="text-theme-primary cursor-pointer"
-        onClick={handleShare}
+      <button
+        data-tooltip-id="share-tooltip"
+        data-tooltip-content="Share"
+        data-tooltip-place="bottom"
+      >
+        <FiShare2
+          size={'1.2rem'}
+          className="text-theme-primary cursor-pointer"
+          onClick={handleShare}
+        />
+      </button>
+      <Tooltip
+        id="share-tooltip"
+        style={{
+          backgroundColor: '#8b5cf6',
+          fontSize: '13px',
+          paddingLeft: '6px',
+          paddingRight: '6px',
+          paddingTop: '2px',
+          paddingBottom: '2px',
+        }}
       />
-        </button>
-      <Tooltip id='share-tooltip' style={{ backgroundColor: '#8b5cf6', fontSize: '13px', paddingLeft: '6px', paddingRight: '6px', paddingTop: '2px', paddingBottom: '2px' }} />
-
+
       {showShareOptions && (
         <p
           className="bg-theme-secondary text-white text-sm rounded-lg px-3 py-1"