Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagination to CardsList.tsx #1177

Closed
wants to merge 10 commits into from

Conversation

siddarthdayala
Copy link

@siddarthdayala siddarthdayala commented Jun 27, 2023

Fixes Issue

Closes #1125

Changes proposed

Added Ant Design Pagination to the CardsList.tsx

Screenshots

image

image

Note to reviewers

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) Jul 23, 2023 4:45pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, siddarthdayala, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good

@ujjawaltyagii
Copy link
Contributor

@siddarthdayala Deployment is getting failed could you remove the merge conflicts first !

@siddarthdayala
Copy link
Author

hey @ujjawaltyagii resolved the conflicts.. Could you please check?

@rupali-codes
Copy link
Owner

@siddarthdayala can you please fix the following errors

image

@rupali-codes rupali-codes added goal: new-feature New feature or request gssoc GirlScript Summer of Code participants level3 Making completely new feature labels Jun 29, 2023
@siddarthdayala
Copy link
Author

@rupali-codes I've changed the code in the file. It resolves the error. Could you please check?

@rupali-codes
Copy link
Owner

@siddarthdayala it doesn't, please checkout this

image

@siddarthdayala
Copy link
Author

siddarthdayala commented Jun 29, 2023

How about now? @rupali-codes Actually, I couldn't view the errors on Vercel, it shows 404 page. But the code is updated now.
Please update if it's throwing more errors.

@k-deepak04
Copy link
Contributor

@rupali-codes please let me know the error so i can help @siddarthdayala

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it looks nice, but there are a few things we would like to add:

  • when clicked on button, it should move user to top
  • (optional) can you add something like an animation when the page changes? it would be more better for UX
  • selected button's text and bg color (blue & white) doesn't match with LinksHub theme, so kindly update that.

Other than this, it looks great to me :)
let us know if you need any kinda help

@k-deepak04
Copy link
Contributor

@siddarthdayala please update the change rupali said.

@siddarthdayala
Copy link
Author

Sure @rupali-codes I'll try the specified changes

@siddarthdayala
Copy link
Author

siddarthdayala commented Jul 2, 2023

@rupali-codes I've made a new commit with few changes once check it

@CBID2
Copy link
Collaborator

CBID2 commented Jul 2, 2023

@rupali-codes I've made a new commit with few changes once check it

@siddarthdayala, there seems to be a deployment issue.

@siddarthdayala
Copy link
Author

@rupali-codes I've made a new commit with few changes once check it

@siddarthdayala, there seems to be a deployment issue.

Hey @CBID2 Could you please post the screenshot of the error? I'll check if it has something to do with the code.

@rupali-codes
Copy link
Owner

@siddarthdayala here

image

@siddarthdayala
Copy link
Author

@rupali-codes I've solved the error, please check it

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddarthdayala could you please resolve this error?

image

@siddarthdayala
Copy link
Author

@rupali-codes I resolved the conflicts

@k-deepak04
Copy link
Contributor

@siddarthdayala the deployment is failing plz check

@siddarthdayala
Copy link
Author

@siddarthdayala the deployment is failing plz check

Could you please post the error here? I can't see the errors

@k-deepak04
Copy link
Contributor

@rupali-codes can you help him with it?

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, i'm sorry for being late, can u please resolve this

image

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

@siddarthdayala, can you fix this, please?

@CBID2 CBID2 added the quick-fix Shouldn't take much time to finish label Aug 10, 2023
@CBID2 CBID2 removed the gssoc GirlScript Summer of Code participants label Aug 19, 2023
@CBID2 CBID2 closed this Aug 19, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Aug 19, 2023

Closing this PR due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request level3 Making completely new feature quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Pagination to the Resources Cards
5 participants