-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pagination to CardsList.tsx #1177
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, siddarthdayala, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good
@siddarthdayala Deployment is getting failed could you remove the merge conflicts first ! |
hey @ujjawaltyagii resolved the conflicts.. Could you please check? |
@siddarthdayala can you please fix the following errors |
@rupali-codes I've changed the code in the file. It resolves the error. Could you please check? |
@siddarthdayala it doesn't, please checkout this |
How about now? @rupali-codes Actually, I couldn't view the errors on Vercel, it shows 404 page. But the code is updated now. |
@rupali-codes please let me know the error so i can help @siddarthdayala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, it looks nice, but there are a few things we would like to add:
- when clicked on button, it should move user to top
- (optional) can you add something like an animation when the page changes? it would be more better for UX
- selected button's text and bg color (blue & white) doesn't match with LinksHub theme, so kindly update that.
Other than this, it looks great to me :)
let us know if you need any kinda help
@siddarthdayala please update the change rupali said. |
Sure @rupali-codes I'll try the specified changes |
@rupali-codes I've made a new commit with few changes once check it |
@siddarthdayala, there seems to be a deployment issue. |
Hey @CBID2 Could you please post the screenshot of the error? I'll check if it has something to do with the code. |
@siddarthdayala here |
@rupali-codes I've solved the error, please check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddarthdayala could you please resolve this error?
@rupali-codes I resolved the conflicts |
@siddarthdayala the deployment is failing plz check |
Could you please post the error here? I can't see the errors |
@rupali-codes can you help him with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siddarthdayala, can you fix this, please? |
Closing this PR due to inactivity |
Fixes Issue
Closes #1125
Changes proposed
Added Ant Design Pagination to the CardsList.tsx
Screenshots
Note to reviewers