Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Sync overlay transition with sidebar transition in mobile view #1264

Conversation

JakubChorzepa
Copy link
Contributor

Fixes Issue

Closes #1007

Changes proposed

Screenshots

Note to reviewers

Used existing react-transition-state library with useTransition hook.

@vercel
Copy link

vercel bot commented Jul 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2023 0:14am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, JakubChorzepa, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@JakubChorzepa JakubChorzepa changed the title 1007 sync overlay transition with sidebar Feat: Sync overlay transition with sidebar transition in mobile view Jul 9, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@CBID2 CBID2 added bug Something isn't working frontend quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level3 Making completely new feature labels Jul 14, 2023
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please describe what changes you've made?

@JakubChorzepa
Copy link
Contributor Author

could you please describe what changes you've made?

Yeah, I've added status and toggle function at component mount using react-transition-state so that now when Backdrop is entering it is transparent and when it is entered it changes its to full visibility.

It allows to add transition so now when side bar is opening the backdrop does not appear instantly after hamburger menu click, it enters with delay and smooth transition.

The transition is optional if we don't pass transition in Backdrop class name while using component it won't have it.

@rupali-codes
Copy link
Owner

could you please describe what changes you've made?

Yeah, I've added status and toggle function at component mount using react-transition-state so that now when Backdrop is entering it is transparent and when it is entered it changes its to full visibility.

It allows to add transition so now when side bar is opening the backdrop does not appear instantly after hamburger menu click, it enters with delay and smooth transition.

The transition is optional if we don't pass transition in Backdrop class name while using component it won't have it.

thanks

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k-deepak04
Copy link
Contributor

@rupali-codes plz merge this, i'm not getting the option to do so.

@k-deepak04 k-deepak04 merged commit e26d771 into rupali-codes:main Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc GirlScript Summer of Code participants level3 Making completely new feature quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Sync overlay transition with sidebar transition in mobile view
4 participants