-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Sync overlay transition with sidebar transition in mobile view #1264
Feat: Sync overlay transition with sidebar transition in mobile view #1264
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, JakubChorzepa, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please describe what changes you've made?
Yeah, I've added status and toggle function at component mount using react-transition-state so that now when Backdrop is entering it is transparent and when it is entered it changes its to full visibility. It allows to add transition so now when side bar is opening the backdrop does not appear instantly after hamburger menu click, it enters with delay and smooth transition. The transition is optional if we don't pass transition in Backdrop class name while using component it won't have it. |
thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@rupali-codes plz merge this, i'm not getting the option to do so. |
Fixes Issue
Closes #1007
Changes proposed
Screenshots
Note to reviewers
Used existing react-transition-state library with useTransition hook.