Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a cpp subcategory under languages #1289

Merged
merged 9 commits into from
Jul 20, 2023
Merged

added a cpp subcategory under languages #1289

merged 9 commits into from
Jul 20, 2023

Conversation

hereisSwapnil
Copy link
Contributor

Fixes Issue

Closes #1199

Changes proposed

I have added CPP Subcategory under Languages with some resources

Screenshots

image

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 0:18am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Swapnil-Singh-99, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 added quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) goal: new-category Addition of new categories related contributions goal: new-link Addition of new links related contributions labels Jul 13, 2023
CBID2
CBID2 previously approved these changes Jul 13, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CBID2 CBID2 requested a review from rupali-codes July 13, 2023 23:56
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the course is for c++ or data structures? bcz if its data structure then it should be in youtube/data-structure

@hereisSwapnil
Copy link
Contributor Author

@CBID2 I have made the changes please review them

CBID2
CBID2 previously approved these changes Jul 15, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swapnil-singh-99 Please don't over-do anything, keep the changes to your issue specifically :)

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swapnil-singh-99

  • Remove any other changes you've made than your issue
  • rename the file ftom c++.json to cpp.json

@hereisSwapnil
Copy link
Contributor Author

@rupali-codes I have made the following changes to the code .
Please review

CBID2
CBID2 previously approved these changes Jul 19, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupali-codes rupali-codes merged commit a441e04 into rupali-codes:main Jul 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-category Addition of new categories related contributions goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] <Languages/C++ Programming>
3 participants