Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added Quine Resources #1351

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

Avdhesh-Varshney
Copy link
Contributor

Fixes Issue - 1188

Closes #1188

Changes proposed

Added quine resources

https://www.youtube.com/playlist?list=PLnCV5fTAsUgpaLMY_Z8FqPxZ89v-_pcfY

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 5:55pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Avdhesh-Varshney, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Avdhesh-Varshney
Copy link
Contributor Author

@rupali-codes @CBID2 please review this pr

CBID2
CBID2 previously approved these changes Jul 19, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Jul 21, 2023
@k-deepak04
Copy link
Contributor

@Avdhesh-Varshney please do the needful that rupali said then we are good to go.

Copy link
Contributor

@k-deepak04 k-deepak04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the needful naming convention changes suggested

Co-authored-by: Rupali Haldiya <78981177+rupali-codes@users.noreply.github.com>
Co-authored-by: Rupali Haldiya <78981177+rupali-codes@users.noreply.github.com>
@k-deepak04
Copy link
Contributor

@rupali-codes plz review and merge this

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CBID2 CBID2 merged commit bb9d1c4 into rupali-codes:main Jul 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Quine Resources
4 participants