Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Passportjs #1353

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Add Passportjs #1353

merged 3 commits into from
Jul 22, 2023

Conversation

AlfiyaSiddique
Copy link
Contributor

Fixes Issue

Issue #1333
closes #1333

Changes proposed

Add the Passport authentication middleware in the backend authentication category

Screenshots

1

Note to reviewers

Please merge this pr with gssoc23 labels

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 1:41pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, AlfiyaSiddique, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlfiyaSiddique. I provided a suggestion on how to improve your description.

database/backend/authentication.json Outdated Show resolved Hide resolved
Better description

Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@AlfiyaSiddique
Copy link
Contributor Author

@CBID2 Thanks for the suggestions. 👍🏻
Improved the description

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made another suggestion for improvement

database/backend/authentication.json Outdated Show resolved Hide resolved
Update Description

Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@AlfiyaSiddique
Copy link
Contributor Author

Did the changes @CBID2

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Jul 21, 2023
@AlfiyaSiddique
Copy link
Contributor Author

LGTM! :)

Yeah, then can you please merge this PR!!

@CBID2 CBID2 requested a review from k-deepak04 July 22, 2023 03:48
@CBID2
Copy link
Collaborator

CBID2 commented Jul 22, 2023

LGTM! :)

Yeah, then can you please merge this PR!!

Two approvals are required for PRs to be merged. Please be patient.

@k-deepak04 k-deepak04 merged commit be588ab into rupali-codes:main Jul 22, 2023
4 checks passed
@AlfiyaSiddique AlfiyaSiddique deleted the passportjs branch July 27, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Passport.js
3 participants