Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding videos on open source #1361

Closed
wants to merge 6 commits into from
Closed

Adding videos on open source #1361

wants to merge 6 commits into from

Conversation

CBID2
Copy link
Collaborator

@CBID2 CBID2 commented Jul 21, 2023

Fixes Issue

Closes #1014
Closes #1015

Changes proposed

I added a new subcategory for the Open Source section and a resource that supports it

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) Jul 21, 2023 2:45am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, CBID2, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish goal: new-category Addition of new categories related contributions labels Jul 21, 2023
@CBID2 CBID2 requested a review from k-deepak04 July 21, 2023 02:48
@k-deepak04
Copy link
Contributor

@CBID2 the deployment is failing, please look into that.
And one thing i want to ask, like can we not just add the yt link in db and export that and link, why have you changed the header code?
just asking i'm totally new and don't know as i was doing the same just adding the resource and linking that but was unable to see the result

@CBID2
Copy link
Collaborator Author

CBID2 commented Jul 21, 2023

@CBID2 the deployment is failing, please look into that.

And one thing i want to ask, like can we not just add the yt link in db and export that and link, why have you changed the header code?

just asking i'm totally new and don't know as i was doing the same just adding the resource and linking that but was unable to see the result

I was trying to add a new subcategory and a merge conflict happened in the header, so I tried solving it and disaster struck

@CBID2 CBID2 closed this Jul 21, 2023
@CBID2
Copy link
Collaborator Author

CBID2 commented Jul 21, 2023

I'll create a better one @k-deepak04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-category Addition of new categories related contributions goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] <Videos to Open Source Category> [Add] <How I choose Maintainers>
3 participants