Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap is added #1381

Closed
wants to merge 3 commits into from
Closed

bootstrap is added #1381

wants to merge 3 commits into from

Conversation

Sushilverma002
Copy link
Contributor

close issue -> #1370

Fixes Issue

Changes proposed

Screenshots

image

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) Jul 27, 2023 11:27pm

github-actions[bot]
github-actions bot reviewed Jul 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sushilverma002, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Sushilverma002
Copy link
Contributor Author

Sushilverma002 commented Jul 24, 2023 •
edited
Loading

@CBID2 have a look. And add a level label too.

@Sushilverma002
Copy link
Contributor Author

@CBID2 please review

@CBID2
Copy link
Collaborator

CBID2 commented Jul 25, 2023

Please be patient @Sushilverma002

@k-deepak04
Copy link
Contributor

@Sushilverma002 please resolve the conflicts

@Sushilverma002
Copy link
Contributor Author

@k-deepak04 conflict resolved. @CBID2

@k-deepak04
Copy link
Contributor

k-deepak04 commented Jul 26, 2023 •
edited
Loading

@Sushilverma002 the deployment is failing.

@Sushilverma002
Copy link
Contributor Author

@k-deepak04 how can i resolve this .

@k-deepak04
Copy link
Contributor

@rupali-codes please provide the ss of whats going wrong

@Sushilverma002
Copy link
Contributor Author

when i click to check what's going wrong it shows:
image
@k-deepak04

@k-deepak04
Copy link
Contributor

when i click to check what's going wrong it shows: image @k-deepak04

only project admin @rupali-codes has the access , be patient she will be helping you out in this.

@Sushilverma002
Copy link
Contributor Author

Okay @k-deepak04

CBID2

This comment was marked as outdated.

Sign in to view

CBID2
CBID2 reviewed Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a grammar error, but still work on this PR

@CBID2 CBID2 dismissed their stale review July 27, 2023 23:29

inaccurate

@CBID2 CBID2 linked an issue Jul 27, 2023 that may be closed by this pull request
[Add] want to create new section of BOOTSTRAP #1370
Closed
4 tasks
@CBID2 CBID2 added quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Jul 27, 2023
@CBID2 CBID2 added the goal: new-category Addition of new categories related contributions label Jul 27, 2023
@Sushilverma002
Copy link
Contributor Author

any update @CBID2 ?

@CBID2
Copy link
Collaborator

CBID2 commented Jul 28, 2023

any update @CBID2 ?

Did you resolve the merge conflicts?

@Sushilverma002
Copy link
Contributor Author

Sushilverma002 commented Jul 28, 2023 •
edited
Loading

i don't know the exact reason of fail deployment. see @CBID2

bootstrap.is.added.by.Sushilverma002.Pull.Request.1381.rupali-codes_LinksHub.-.Google.Chrome.2023-07-28.23-05-46.mp4

@CBID2
Copy link
Collaborator

CBID2 commented Jul 28, 2023

i don't know the exact reason of fail deployment. see @CBID2

bootstrap.is.added.by.Sushilverma002.Pull.Request.1381.rupali-codes_LinksHub.-.Google.Chrome.2023-07-28.23-05-46.mp4

To move things quickly, I think you should do a new version of this PR with a different branch @Sushilverma002

@CBID2 CBID2 closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBID2 CBID2 CBID2 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@ujjawaltyagii ujjawaltyagii Awaiting requested review from ujjawaltyagii

@rupali-codes rupali-codes Awaiting requested review from rupali-codes rupali-codes is a code owner

Assignees

@Sushilverma002 Sushilverma002

Labels
goal: new-category Addition of new categories related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] want to create new section of BOOTSTRAP
3 participants
@Sushilverma002 @CBID2 @k-deepak04