Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variables for different colors #1390

Closed

Conversation

PriyansuMaurya
Copy link
Contributor

@PriyansuMaurya PriyansuMaurya commented Jul 26, 2023

Fixes Issue

Closes #1191

Changes proposed

Screenshots

image

image

image

image

Note to reviewers

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 0:11am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, PriyansuMaurya, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@rupali-codes
Copy link
Owner

@PriyansuMaurya Not acutally, a day before yesterday we have put the colors in tailwind.config.css file and just change the colors value in there, isn't your local codebase updated?

@PriyansuMaurya
Copy link
Contributor Author

No, its not. I forgot to update 😓.

what should I do now?

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PriyansuMaurya. Consider placing the colors in the file @rupali-codes mentioned. Also, solve the merge conflicts in your branch.

@CBID2 CBID2 added quick-fix Shouldn't take much time to finish goal: refactor Refactoring the codebase labels Jul 27, 2023
@rupali-codes
Copy link
Owner

No, its not. I forgot to update 😓.

what should I do now?

  • close this PR
  • update your local repo with linkshub:main
  • make changes in only tailwind.config.js file as we've gathered all the colors in there

please let us know for any kinda help

@PriyansuMaurya
Copy link
Contributor Author

please let us know for any kinda help

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: refactor Refactoring the codebase quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Font Color
3 participants