Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve sidenavbar body with opacity #1425

Merged
merged 3 commits into from
Aug 9, 2023
Merged

fix: improve sidenavbar body with opacity #1425

merged 3 commits into from
Aug 9, 2023

Conversation

Anmol-Baranwal
Copy link
Collaborator

Fixes Issue

Closes #1420

Changes proposed

  • Fixed the issue mentioned in the issue description

Screenshots

image

Note to reviewers

It always feels amusing when such a great issue, which has such a significant impact, is fixed in just one line, even though it takes time to find that one line.

@vercel
Copy link

vercel bot commented Jul 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 8:18am

github-actions[bot]
github-actions bot reviewed Jul 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

CBID2
CBID2 previously approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good

rupali-codes
rupali-codes reviewed Jul 31, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the color to grayish as we are not using white anywhere

@rupali-codes rupali-codes added quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level2 Modifying an existing feature labels Jul 31, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

can you change the color to grayish as we are not using white anywhere

Sure.

@Anmol-Baranwal
Copy link
Collaborator Author

can you change the color to grayish as we are not using white anywhere

Decreasing opacity
image

Using gray color, seems to mess with navigation list.
image

@rupali-codes
What should I do?
White seems to be good for accessibility and visual appeal.

@rupali-codes
Copy link
Owner

can you change the color to grayish as we are not using white anywhere

Decreasing opacity
image

Using gray color, seems to mess with navigation list.
image

@rupali-codes What should I do? White seems to be good for accessibility and visual appeal.

alright then, we can use white, but only for Mobile devices, for desktop it should be as it is :)

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
I have done it for general just to correct the opacity. I am not changing any color theme. So, please look into this.

k-deepak04
k-deepak04 reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@k-deepak04 k-deepak04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anmol-Baranwal please share the screenshots after changes requested by @rupali-codes

@Anmol-Baranwal
Copy link
Collaborator Author

@Anmol-Baranwal please share the screenshots after changes requested by @rupali-codes

@k-deepak04
Done.

image

rupali-codes
rupali-codes approved these changes Aug 8, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

CBID2
CBID2 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@CBID2 CBID2 added the goal: refactor Refactoring the codebase label Aug 9, 2023
@CBID2 CBID2 merged commit e283b2d into rupali-codes:main Aug 9, 2023
4 checks passed
@Anmol-Baranwal Anmol-Baranwal deleted the hack_improve_sidebar branch August 9, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-deepak04 k-deepak04 k-deepak04 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@ujjawaltyagii ujjawaltyagii Awaiting requested review from ujjawaltyagii

Assignees

@Anmol-Baranwal Anmol-Baranwal

Labels
goal: refactor Refactoring the codebase gssoc GirlScript Summer of Code participants level2 Modifying an existing feature quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] improve sidebar to make elements visually accessible
4 participants
@Anmol-Baranwal @rupali-codes @k-deepak04 @CBID2