Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apis in backend #1457

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Added apis in backend #1457

merged 6 commits into from
Aug 7, 2023

Conversation

Deepanshu0703
Copy link
Contributor

@Deepanshu0703 Deepanshu0703 commented Aug 1, 2023

Fixes Issue

Closes #1281

Changes proposed

Added API section in backend and resources into it.

Screenshots

image

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2023 7:15am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Deepanshu0703, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a few suggestions for improvement @Deepanshu0703

database/backend/api.json Outdated Show resolved Hide resolved
database/backend/api.json Outdated Show resolved Hide resolved
@CBID2 CBID2 requested a review from rupali-codes August 1, 2023 15:11
Deepanshu0703 and others added 2 commits August 2, 2023 17:44
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@Deepanshu0703
Copy link
Contributor Author

Done @CBID2

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please format the resources properly in this format

@rupali-codes rupali-codes added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Aug 2, 2023
@Deepanshu0703
Copy link
Contributor Author

Done @rupali-codes

CBID2
CBID2 previously approved these changes Aug 3, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Deepanshu0703! :) I made a few tweaks in the descriptions.
In the future, consider running your descriptions through Grammarly or Spellcheck before making a pull request. Other than that, you're off to a great start! :)

@CBID2 CBID2 requested a review from rupali-codes August 3, 2023 18:59
@Deepanshu0703
Copy link
Contributor Author

Thanks @CBID2 , i will make sure it in the future. Thanks for your advice.

@Deepanshu0703
Copy link
Contributor Author

hey @rupali-codes please review it

1 similar comment
@Deepanshu0703
Copy link
Contributor Author

hey @rupali-codes please review it

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@rupali-codes rupali-codes merged commit acadde1 into rupali-codes:main Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] Add hosting and API section in backend category
3 participants