Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: text overlap in search result #1471

Merged
merged 9 commits into from
Aug 10, 2023
Merged

fix bug: text overlap in search result #1471

merged 9 commits into from
Aug 10, 2023

Conversation

harmeetsingh11
Copy link
Contributor

@harmeetsingh11 harmeetsingh11 commented Aug 2, 2023 •
edited by CBID2
Loading

Fixes

Closes #1218

Changes proposed

Simply display #Search: Results Not Found or #Search: Results Found, and it will change based on the click or further interactions.

Files modified/added

  • components/TopBar/TopBar.tsx
  • components/Header/Header.tsx
  • pages/_app.tsx
  • pages/search.tsx
  • hooks/ResultsContext.tsx

Screenshots

Before this PR

image

After this PR

LinksHub.webm

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes have not introduced any new warnings.

@vercel
Copy link

vercel bot commented Aug 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 10:41am

@github-actions github-actions bot added the bug Something isn't working label Aug 2, 2023
github-actions[bot]
github-actions bot reviewed Aug 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, harmeetsingh11, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@harmeetsingh11
Copy link
Contributor Author

Hey @rupali-codes, @CBID2, @ujjawaltyagii please review this PR.
Thanks

@CBID2
Copy link
Collaborator

CBID2 commented Aug 3, 2023

Hmm... for some reason the deployment build failed. @rupali-codes, can you describe the deployment error? I can't see it because I don't have access to your Vercel account.

@rupali-codes
Copy link
Owner

@harmeetsingh11 and @CBID2 i'm sorry for being late, your vercel deployment is getting failed because of the following error

image

@harmeetsingh11
Copy link
Contributor Author

@rupali-codes , @CBID2 I have fixed the error. Please check it.

@CBID2
Copy link
Collaborator

CBID2 commented Aug 7, 2023

@rupali-codes , @CBID2 I have fixed the error. Please check it.

Can you post another link to your screenshot video @harmeetsingh11? I'm having trouble visualizing the changes you made.

@harmeetsingh11
Copy link
Contributor Author

@rupali-codes , @CBID2 I have fixed the error. Please check it.

Can you post another link to your screenshot video @harmeetsingh11? I'm having trouble visualizing the changes you made.

Sure @CBID2 . Here it is. Please do let me know, in case this doesn't works.

screenshot.video.mp4

rupali-codes
rupali-codes reviewed Aug 7, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks great, lets just improve the texts

CBID2
CBID2 previously approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 requested a review from rupali-codes August 7, 2023 15:36
@harmeetsingh11
Copy link
Contributor Author

@rupali-codes I've made the suggested changes. Please review it.

LinksHub.webm

rupali-codes
rupali-codes previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect to me, thanks a lot!

@CBID2 CBID2 added gssoc GirlScript Summer of Code participants level2 Modifying an existing feature goal: refactor Refactoring the codebase labels Aug 9, 2023
@CBID2 CBID2 added good first issue Good for newcomers and removed goal: refactor Refactoring the codebase labels Aug 9, 2023
CBID2
CBID2 requested changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harmeetsingh11. One of the tests had an error. Fix it and tag me when you're ready for another review.

@harmeetsingh11
Copy link
Contributor Author

@CBID2 I've fixed the error. Hope it will work.

@CBID2
Copy link
Collaborator

CBID2 commented Aug 9, 2023

@CBID2 I've fixed the error. Hope it will work.

It still failed @harmeetsingh11

@harmeetsingh11
Copy link
Contributor Author

@CBID2 please check.

CBID2
CBID2 previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 requested a review from k-deepak04 August 10, 2023 01:33
@CBID2 CBID2 added the status: ready-to-merge Approved & its ready-to-merge label Aug 10, 2023
CBID2
CBID2 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupali-codes rupali-codes merged commit 63d6a00 into rupali-codes:main Aug 10, 2023
5 checks passed
@harmeetsingh11 harmeetsingh11 deleted the fix-issue-1218 branch October 12, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@ujjawaltyagii ujjawaltyagii Awaiting requested review from ujjawaltyagii

@k-deepak04 k-deepak04 Awaiting requested review from k-deepak04

Assignees

@harmeetsingh11 harmeetsingh11

Labels
bug Something isn't working good first issue Good for newcomers gssoc GirlScript Summer of Code participants level2 Modifying an existing feature status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Text overlap in search result.
3 participants
@harmeetsingh11 @CBID2 @rupali-codes