Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add aria label attribute to every link & button #1472

Merged
merged 2 commits into from
Aug 8, 2023
Merged

chore: add aria label attribute to every link & button #1472

merged 2 commits into from
Aug 8, 2023

Conversation

Anmol-Baranwal
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal commented Aug 3, 2023 •
edited
Loading

Fixes Issue

Closes #1467
Closes #1463

Changes proposed

  • add aria-label attributes as mentioned in the issue description

Note to reviewers

  • Please ignore unverified state, as I have made the necessary changes. It will be verified from now.

@vercel
Copy link

vercel bot commented Aug 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 5:46am

@github-actions github-actions bot added quick-fix Shouldn't take much time to finish goal: new-link Addition of new links related contributions labels Aug 3, 2023
github-actions[bot]
github-actions bot reviewed Aug 3, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator Author

This also fixes #1463

Before:
image

After:
image

@CBID2 CBID2 added gssoc GirlScript Summer of Code participants level2 Modifying an existing feature accessibility Code is not up to WCAG standards and removed goal: new-link Addition of new links related contributions labels Aug 3, 2023
CBID2
CBID2 previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
Please merge this till end of today.

@rupali-codes rupali-codes merged commit 95d0e09 into rupali-codes:main Aug 8, 2023
4 checks passed
@Anmol-Baranwal Anmol-Baranwal deleted the hack_aria_label branch August 8, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@k-deepak04 k-deepak04 k-deepak04 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

@CBID2 CBID2 CBID2 left review comments

@ujjawaltyagii ujjawaltyagii Awaiting requested review from ujjawaltyagii

Assignees

@Anmol-Baranwal Anmol-Baranwal

Labels
accessibility Code is not up to WCAG standards gssoc GirlScript Summer of Code participants level2 Modifying an existing feature quick-fix Shouldn't take much time to finish
Projects
None yet
Milestone
No milestone
4 participants
@Anmol-Baranwal @rupali-codes @k-deepak04 @CBID2