Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add close button on popup #1485

Merged
merged 7 commits into from
Aug 9, 2023
Merged

chore: add close button on popup #1485

merged 7 commits into from
Aug 9, 2023

Conversation

k-deepak04
Copy link
Contributor

@k-deepak04 k-deepak04 commented Aug 4, 2023 •
edited by CBID2
Loading

closes

Closes #1484

Changes proposed

Screenshots

Screenshot 2023-08-04 180130

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 8:08am

github-actions[bot]
github-actions bot reviewed Aug 4, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, k-deepak04, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@k-deepak04
Copy link
Contributor Author

@CBID2 Please go ahead and review it
Speed 🥷🐢.

@CBID2 CBID2 added bug Something isn't working gssoc GirlScript Summer of Code participants level3 Making completely new feature goal: refactor Refactoring the codebase and removed goal: refactor Refactoring the codebase labels Aug 4, 2023
CBID2
CBID2 previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-deepak04
Copy link
Contributor Author

@rupali-codes please review and merge.

rupali-codes
rupali-codes reviewed Aug 5, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not looking good actually,

can you add something like close text right after the visit button?

like this
image

@rupali-codes rupali-codes added level2 Modifying an existing feature and removed level3 Making completely new feature labels Aug 5, 2023
@k-deepak04
Copy link
Contributor Author

its not looking good actually,

can you add something like close text right after the visit button?

like this image

okay i'll do this

@k-deepak04
Copy link
Contributor Author

image

web

image

phone

@rupali-codes @CBID2 please check and let me know

@CBID2
Copy link
Collaborator

CBID2 commented Aug 5, 2023

Looks pretty good to me @k-deepak04

@k-deepak04
Copy link
Contributor Author

Looks pretty good to me @k-deepak04

thanks :)
the previous level tag was also looking pretty good on this issue 🤣🤣

@k-deepak04
Copy link
Contributor Author

@rupali-codes please merge this one too

@rupali-codes rupali-codes changed the title symbol added chore: add close button on popup Aug 8, 2023
@rupali-codes
Copy link
Owner

@k-deepak04 it has too much spacing, could you please it? also please reduce the font-size

image

@k-deepak04
Copy link
Contributor Author

ok will do it now

@k-deepak04
Copy link
Contributor Author

image

will this works?

@k-deepak04
Copy link
Contributor Author

image

phone view

@k-deepak04
Copy link
Contributor Author

@rupali-codes let me know

@k-deepak04
Copy link
Contributor Author

@rupali-codes commited the changes you said :)

@rupali-codes rupali-codes merged commit d734474 into main Aug 9, 2023
5 checks passed
@rupali-codes rupali-codes deleted the Deep branch August 9, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rupali-codes rupali-codes rupali-codes approved these changes

@CBID2 CBID2 CBID2 left review comments

@ujjawaltyagii ujjawaltyagii Awaiting requested review from ujjawaltyagii

Assignees

@k-deepak04 k-deepak04

Labels
bug Something isn't working gssoc GirlScript Summer of Code participants level2 Modifying an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Add a close symbol to the card pop-up.
3 participants
@k-deepak04 @CBID2 @rupali-codes