refactor: improve functionality and accessibility for share and copy components 🪄✨ #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xabdulkhaliq
requested review from
ujjawaltyagii,
CBID2 and
rupali-codes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
accessibility
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hey there Guys 👋🏻 @rupali-codes, @CBID2 & @k-deepak04 Make sure to review this PR, So that we can quickly wrap this up. Otherwise I want to resolve merge conflicts once again. Thank You! |
CBID2
added
gssoc
|
@0xabdulkhalid can u please resolve conflicts asap? |
|
@rupali-codes Conflicts are resolved! Please merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Close #1479
Note
This is PR is a retry of #1492
Changes proposed
This PR introduces several significant enhancements to the
CopyToClipboard.tsxandShare.tsxfiles, focusing on code refactoring and accessibility improvements. The key changes are as follows:Code Refactoring: Both
CopyToClipboard.tsxandShare.tsxcomponents have undergone code refactoring to remove unnecessary elements, such as wrapping divs, and improve code readability and maintainability.Improved Accessibility: The accessibility of the components has been greatly enhanced. We replaced the
titleattributes with more descriptive and accessiblearia-labelattributes for the icons. Additionally, we introducedaria-live="polite"to announce changes to screen readers in a polite manner.Styling Enhancement: The inline styles in the components have been removed, and we now rely on CSS classes for styling. This makes the code more organized and easier to manage.
Reduced Bloatware: We have trimmed unnecessary elements and styles, resulting in a leaner and more efficient codebase.
Icon Change on Success: When the copy action is successful, the copy icon now changes to a checkmark icon (
FaCheckSquare). This gives users clear feedback on the success of the copy operation.Resetting Copied Icon: The copied icon now resets back to the original copy icon (
FaRegCopy) after 2 seconds, ensuring a smoother user experience.With these improvements, the
CopyToClipboardandSharecomponents are now more accessible, efficient, and user-friendly. The PR contributes to the overall enhancement of the repository's codebase and user experience.