Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Text overflowing in top bar #1540

Closed
wants to merge 2 commits into from
Closed

Conversation

Semako123
Copy link

Fixes Issue

Closes #1218

Changes proposed

I made the text scroll in the container rather than overflowing on the other content of the top bar

Screenshots

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2023 5:08pm

@github-actions github-actions bot added the bug Something isn't working label Aug 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Semako123, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

Can you add screenshot or screen recording of the changes you're proposing @Semako123? It'll give me an idea of what to look for.

@rupali-codes
Copy link
Owner

@Semako123 can u please add sceenshorts of your changes?

@CBID2
Copy link
Collaborator

CBID2 commented Aug 10, 2023

Also solve the merge conflicts @Semako123

@rupali-codes
Copy link
Owner

@Semako123 any updates?

@Semako123
Copy link
Author

Untitled.video.mp4

This is a preview of the change I made
Sorry for the delay.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 requested review from Anmol-Baranwal and removed request for ujjawaltyagii August 20, 2023 21:30
@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Aug 21, 2023

@rupali-codes @CBID2
This is not needed anymore. There was a PR that helped in showing the query: Results Found & Results Not Found

image

@CBID2
Copy link
Collaborator

CBID2 commented Aug 21, 2023

@rupali-codes @CBID2

This is not needed anymore. There was a PR that helped in showing the query: Results Found & Results Not Found

image

Thanks for pointing that out @Anmol-Baranwal

@CBID2 CBID2 closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Text overlap in search result.
4 participants