Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1554

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

abhisar-yadav
Copy link
Contributor

@abhisar-yadav abhisar-yadav commented Aug 10, 2023

Corrected grammatical errors in the Contributing page

Fixes

Closes #1509
Relates #1553 and #1555

CORRECTED GRAMMATICAL ERRORS IN CONTRIBUTING PAGE
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 5:29pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, abhisar-yadav, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions. I kept the part where it describes the JSON format in lowercase because arrays are not capitalized

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@CBID2 CBID2 mentioned this pull request Aug 10, 2023
@CBID2 CBID2 added documentation Improvements or additions to documentation quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels Aug 10, 2023
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@abhisar-yadav
Copy link
Contributor Author

kindly merge the PR
THANK YOU

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You just need a second approval

@CBID2 CBID2 requested review from k-deepak04 and CBID2 August 10, 2023 17:41
@k-deepak04 k-deepak04 merged commit ffe40a5 into rupali-codes:main Aug 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] UPDATE README,SECURITY,AND CONTRIBUTING PAGE
3 participants