feat: implement adaptive day/night browser bar theme 🚀🔥 #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xabdulkhaliq
requested review from
ujjawaltyagii,
CBID2 and
rupali-codes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
You can test this deployment on your Mobile Chrome Browser, You must want to enable light theme for it. Because using Dark theme on Chrome will enforce and overwrite site's theme. |
|
@rupali-codes, @CBID2, @k-deepak04 👋🏻 Please make sure to review this PR as soon as possible, Thank You! |
|
Can you show a screenshot of this @0xabdulkhalid? |
|
@CBID2 PR Description has been updated now, You can check that out! Check those screenshots above. |
CBID2
added
quick-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Close #1506
Description
Changes introduced
Dynamic Browser Bar Color: Depending on the selected theme (dark or light), the browser's address bar will adapt its color accordingly, providing a seamless visual transition and consistency.
PWA Compatibility: This feature is fully compatible with the PWA version of LinksHub, ensuring that users who've installed LinksHub on their devices get a consistent and immersive experience.
Advantages
Enhanced User Experience: The adaptation of the browser bar color according to the app theme offers users a unified and more engaging visual experience.
Consistency: Whether accessing LinksHub from a desktop browser or as a PWA on mobile, users will experience a harmonious UI.
Aesthetic Appeal: This subtle design change contributes significantly to the overall aesthetics of the platform, making the app not just functional, but visually pleasing.
Impact on PWAs
PWAs are all about delivering an app-like experience on the web.
This browser bar theme feature further bridges the gap between traditional web apps and native mobile apps, ensuring that our users get the best of both worlds.
This PR is a testament to our commitment to continuously improve and adapt to modern design principles, ensuring that LinksHub remains at the forefront of usability and design. We believe these changes will further solidify LinksHub's position as a leading platform in its domain.
Screenshots (Mobile)