Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added json data in backend/caching.json #1591

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

Sahilll15
Copy link
Contributor

Enhancing Backend Caching Information

Fixes Issue

Closes #1505

Proposed Changes

In this pull request, I have made substantial updates to the database/backend/caching.json file to improve the caching functionality in the backend.

Changes Made

I have enriched the caching.json file with additional and comprehensive information about the caching mechanisms in the backend. This includes details about caching strategies, implementation approaches, and best practices for optimal performance. By providing this in-depth information, we aim to empower developers and team members to make informed decisions regarding caching in our backend system.

Screenshots

Caching Changes
Screenshot of the updated changes showcasing the added information.

Note to Reviewers

Dear Reviewers,

In this pull request, I have focused on enhancing the documentation related to backend caching in the caching.json file. The changes aim to provide a comprehensive resource for developers and team members to understand the caching implementation in the backend better.

I have meticulously reviewed the content to ensure accuracy and clarity. The added information should serve as a valuable reference, especially for those working on optimizing backend performance.

Thank you for your time and consideration. Your feedback is highly appreciated.

Best regards,
[@Sahilll15]

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 7:34am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sahilll15, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some tweaks that I made to your description @Sahilll15. In the future, consider running your descriptions through Grammarly before adding them as PRs. Other than that, you're off to a great start! :)

@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish labels Aug 11, 2023
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sahilll15
Copy link
Contributor Author

LGTM

Cool

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sahilll15 thanks. Please read and follow the CONTRIBUTING guidelines to learn about category and subcategories.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sahilll15! :) I pointed out some proofreading errors that could be improved. Consider using Grammarly to help you revise them.

@Sahilll15
Copy link
Contributor Author

@CBID2 please have a look

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CBID2
CBID2 previously approved these changes Aug 20, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@Sahilll15 Sahilll15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look

@CBID2 CBID2 dismissed their stale review August 20, 2023 20:45

Need a redo

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2
Copy link
Collaborator

CBID2 commented Aug 20, 2023

I can't merge it @rupali-codes

@Sahilll15
Copy link
Contributor Author

please merge it!!

@Sahilll15
Copy link
Contributor Author

@k-deepak04 please review it!

@CBID2 CBID2 requested review from Anmol-Baranwal and removed request for k-deepak04 August 22, 2023 14:17
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal merged commit ff29f51 into rupali-codes:main Aug 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Add caching resources in the website
4 participants