-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix database config #1609
Fix database config #1609
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, shreedhar37, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shreedhar37
Why was the data.ts changed? What was wrong in the previous one. Let me know, then I will cross check it.
Hi @Anmol-Baranwal previously the value for The main issue was with |
Change the value to something more unique. Because we already have a similar name |
Ahh totally missed that @Anmol-Baranwal. Thanks for bringing that up. But I am confused now, there are some values inside |
No worries, I will let you know soon. Please don't make any new changes, until we are sure what to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is nothing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
Thanks @Anmol-Baranwal @rupali-codes @CBID2 this is my first open source contribution in life. |
Nice :) Wishing you the best on your open-source journey. |
|
Fixes Issue
Closes #1607, #1594
Changes proposed
I have updated the
url
andresources
to correct values indata.ts
which were causing issue previously.Screenshots
Note to reviewers