Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database config #1609

Merged
merged 9 commits into from
Aug 21, 2023
Merged

Conversation

shreedhar37
Copy link
Contributor

@shreedhar37 shreedhar37 commented Aug 20, 2023

Fixes Issue

Closes #1607, #1594

Changes proposed

I have updated the url and resources to correct values in data.ts which were causing issue previously.

Screenshots

image

Note to reviewers

@vercel
Copy link

vercel bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 3:32pm

@github-actions github-actions bot added the bug Something isn't working label Aug 20, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, shreedhar37, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shreedhar37

Why was the data.ts changed? What was wrong in the previous one. Let me know, then I will cross check it.

@shreedhar37
Copy link
Contributor Author

shreedhar37 commented Aug 20, 2023

Hi @Anmol-Baranwal previously the value for url was /youtube-testing and for resources it was DB.youtubeTesting, which was causing the issue.

The main issue was with resources value, but I also changed url to match with other urls present in youtube

@Anmol-Baranwal
Copy link
Collaborator

@shreedhar37

Change the value to something more unique. Because we already have a similar name testing for backend. You can check here.

@shreedhar37
Copy link
Contributor Author

Ahh totally missed that @Anmol-Baranwal. Thanks for bringing that up. But I am confused now, there are some values inside databases/youtube/testing.json which are already present inside databases/backend/testing.json. Should I keep only unique values or is it okay to have the same values in both files ?

@Anmol-Baranwal
Copy link
Collaborator

Ahh totally missed that @Anmol-Baranwal. Thanks for bringing that up. But I am confused now, there are some values inside databases/youtube/testing.json which are already present inside databases/backend/testing.json. Should I keep only unique values or is it okay to have the same values in both files ?

No worries, I will let you know soon.

Please don't make any new changes, until we are sure what to do.

CBID2
CBID2 previously approved these changes Aug 20, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anmol-Baranwal
Copy link
Collaborator

Ahh totally missed that @Anmol-Baranwal. Thanks for bringing that up. But I am confused now, there are some values inside databases/youtube/testing.json which are already present inside databases/backend/testing.json. Should I keep only unique values or is it okay to have the same values in both files ?

There is nothing in backend/testing.json. So, there won't be any changes needed except for unique names (rather than testing)

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Anmol-Baranwal Anmol-Baranwal merged commit 285533c into rupali-codes:main Aug 21, 2023
1 check passed
@shreedhar37
Copy link
Contributor Author

Thanks @Anmol-Baranwal @rupali-codes @CBID2 this is my first open source contribution in life.

@Anmol-Baranwal
Copy link
Collaborator

Thanks @Anmol-Baranwal @rupali-codes @CBID2 this is my first open source contribution in life.

Nice :)

Wishing you the best on your open-source journey.

@rupali-codes
Copy link
Owner

Thanks @Anmol-Baranwal @rupali-codes @CBID2 this is my first open source contribution in life.
glad to know.
Happy open-sourceing!!!

@shreedhar37 shreedhar37 deleted the fixDatabaseConfig branch August 22, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] There is no resources present for "Testing" due to wrong configs
4 participants