fix: improve accessibility of scripts #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
accessibility
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Merged
Anmol-Baranwal
requested changes
Sep 4, 2023
Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com>
Just made the change @Anmol-Baranwal! :) It worked! :) |
Anmol-Baranwal
previously approved these changes
Sep 4, 2023
|
Hey @rupali-codes. Can you merge this please? |
rupali-codes
approved these changes
Sep 18, 2023
Sure, sorry for being late |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #1464
Changes proposed
This PR adds ordered lists (
<ol>) around the GitHub buttons and social media icons in theSocialMediaIconsListcomponent, making the code more accessible for screen readers.Screenshots
Note to reviewers
Hey @Anmol-Baranwal. I've never really worked with Typescript before, so feel free to make the necessary adjustments.