-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To fix #2254 Breadcrumbs issue #2261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, sarava338, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
@sarava338 Do you need any help. |
Hi @Anmol-Baranwal, That svg icon is not fixed. I need help with that. I was not able to find the icon. Could you assist that? |
@sarava338 I guess I misunderstood, I will check and let you know. |
Hi @sarava338 The icon you were saying is in And the other component is I hope this helps :D Let me know if you need anything else. |
Thank you @Anmol-Baranwal for find that culprit svg I am going to use |
Completed the issue. But still, there is a small style differentiation inbetween the two components |
@rupali-codes |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
There is a slight difference in font weight, but that's okay for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fixes Issue #2254
Changes proposed
appears whenever we're in sub category
Icon we have, as HomeIcon.svg
The Mysterious Icon not able to find in the code. But in the page
Screenshots
Note to reviewers
Not completed yet. help needed.
I could not able to find the icon I mentioned as mysterious ICON. Please let me know if you know this...