Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new JavaScript charting libraries #2321

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

JuanPabloDiaz
Copy link
Contributor

@JuanPabloDiaz JuanPabloDiaz commented Mar 22, 2024

Fixes Issue

fixes #2289

Changes proposed

Add new JavaScript charting libraries

Screenshots

Note to reviewers

In the interest of providing additional context, I've included some further resources.

Additional resources:

  • Vega is a visualization grammar, a declarative format for creating, saving, and sharing interactive visualization designs.
  • Victory is a React.js components for modular charting and data visualization.
  • C3js is a D3-based reusable chart library.

Copy link

vercel bot commented Mar 22, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, JuanPabloDiaz, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

This was referenced Mar 22, 2024
@Anmol-Baranwal
Copy link
Collaborator

@JuanPabloDiaz
Please link the issues to all of your PRs correctly, so it's easier for us.

use: fixes #<issue_number>

@JuanPabloDiaz
Copy link
Contributor Author

JuanPabloDiaz commented Mar 24, 2024

I believe that's what I did @Anmol-Baranwal.

Do I need the prefix fixes before #?

@Anmol-Baranwal
Copy link
Collaborator

image

This is the correct way. This will close the issues when the PRs are merged.

image

@JuanPabloDiaz
Copy link
Contributor Author

Great to know, thanks!

Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 4:04pm

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2
Copy link
Collaborator

CBID2 commented Mar 26, 2024

Looks like there is a deployment issue @rupali-codes

@Anmol-Baranwal Anmol-Baranwal added the status: ready-to-merge Approved & its ready-to-merge label Mar 27, 2024
@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Please merge this.

@rupali-codes rupali-codes merged commit 160026f into rupali-codes:main Mar 27, 2024
11 checks passed
@JuanPabloDiaz JuanPabloDiaz deleted the jsCharts branch March 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Tremor & Recharts
5 participants