Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changes backgound-color at ::selection attribute #2415

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

GabrielBittar
Copy link
Contributor

Closes issue #2412

Changes proposed

Background-color for selection changed to purple, as discussed in issue #2412.

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 8:27pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, GabrielBittar, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@github-actions github-actions bot added goal: new-feature New feature or request priority: high Making completely new feature labels Jul 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
5 tasks
@GabrielBittar GabrielBittar changed the title [FEATURE] Closes Issue #2412 feat: changes backgound-color at ::selection attribute Jul 13, 2024
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GabrielBittar could you please change the text color to light gray so it would look a little better.

image

@rupali-codes rupali-codes linked an issue Jul 16, 2024 that may be closed by this pull request
3 tasks
@GabrielBittar
Copy link
Contributor Author

Hey @GabrielBittar could you please change the text color to light gray so it would look a little better.

Done

styles/globals.css Outdated Show resolved Hide resolved
Co-authored-by: Rupali Haldiya <78981177+rupali-codes@users.noreply.github.com>
@GabrielBittar
Copy link
Contributor Author

Done

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 1780740 into rupali-codes:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request priority: high Making completely new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement non standard text highlight color
3 participants