Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: erase Youtube category #2489

Merged
merged 18 commits into from
Sep 15, 2024
Merged

Conversation

GabrielBittar
Copy link
Contributor

@GabrielBittar GabrielBittar commented Sep 8, 2024

Fixes Issue

Closes #2474

Changes proposed

Dissolved YouTube categories into its respective subjects

Note to reviewers

Also moved DSA links to data_structures respective folders, as discussed in the issue.

Copy link

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 3:59pm

@github-actions github-actions bot added goal: refactor Refactoring the codebase priority: medium Modifying an existing feature labels Sep 8, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@GabrielBittar GabrielBittar changed the title refactor: [] [Refactor] Erase Youtube category Sep 8, 2024
CBID2
CBID2 previously approved these changes Sep 8, 2024
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @Anmol-Baranwal What do you think?

@CBID2 CBID2 changed the title [Refactor] Erase Youtube category fix: Erase Youtube category Sep 8, 2024
@CBID2 CBID2 changed the title fix: Erase Youtube category fix: erase Youtube category Sep 8, 2024
@CBID2 CBID2 dismissed their stale review September 8, 2024 16:58

Need to do a redo

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rupali-codes rupali-codes merged commit 08ba621 into rupali-codes:main Sep 15, 2024
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: refactor Refactoring the codebase priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Erase Youtube category
3 participants