Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navbar): Created a subcategory Hacktoberfest under open-source c… #2519

Merged
merged 5 commits into from
Oct 12, 2024

Conversation

RJPalmer
Copy link
Contributor

@RJPalmer RJPalmer commented Oct 2, 2024

…ategory (#2515)

Fixes Issue

Fixes #2515

Changes proposed

  • adds 'Hacktoberfest' subcategory to data.ts
  • adds 'Hacktoberfest' subcategory to index.ts
  • adds 'Hacktoberfest' subcategory to CategoryDescriptions.ts
  • adds 'new' text to 'open-source' category in SideNavBar

Screenshots

Note to reviewers

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:08pm

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-feature New feature or request priority: high Making completely new feature priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels Oct 2, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@rupali-codes
Copy link
Owner

@RJPalmer could you please resolve the error?
image

@RJPalmer
Copy link
Contributor Author

RJPalmer commented Oct 3, 2024

Will do

@RJPalmer
Copy link
Contributor Author

RJPalmer commented Oct 3, 2024

@rupali-codes The changes have been made. Please review

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RJPalmer please remove the new tag

Removal of the "new tag" in accordance to rupali-codes#2519 (review)
@RJPalmer
Copy link
Contributor Author

RJPalmer commented Oct 7, 2024

@RJPalmer please remove the new tag

@rupali-codes This has been completed

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RJPalmer
Copy link
Contributor Author

@Anmol-Baranwal @CBID2 @aftabrehan Please review & let me know if any further changes are needed

@rupali-codes rupali-codes merged commit b55fc26 into rupali-codes:main Oct 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions goal: new-feature New feature or request priority: high Making completely new feature priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] Create new subcategory Hacktoberfest
2 participants