Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x docker build #198

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Add s390x docker build #198

merged 2 commits into from
Apr 27, 2024

Conversation

lysliu
Copy link
Contributor

@lysliu lysliu commented Apr 15, 2024

Fixes: #197

Update x.py add s390x by

@@ -21,6 +21,7 @@ debian_arches = [
 
 debian_non_buster_arches = [
     DebianArch("ppc64le", "ppc64el", "linux/ppc64le", "powerpc64le-unknown-linux-gnu"),
+    DebianArch("s390x", "s390x", "linux/s390x", "s390x-unknown-linux-gnu"),
 ]

debian_variants = [
then run

python3 x.py update

to update docker file

Signed-off-by: Yan Song Liu <lysliu@cn.ibm.com>
Signed-off-by: Yan Song Liu <lysliu@cn.ibm.com>
Copy link
Member

@Muscraft Muscraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I want to note that I have no way of testing s390x, so it will be supported on a best-effort case.

If you are up for getting pings when there are issues with s390x, please let me know! It would be appreciated.

@Muscraft Muscraft merged commit 06a886d into rust-lang:master Apr 27, 2024
16 checks passed
@Muscraft
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add s390x docker image support
2 participants